BUG: Change the prompt on non list record path errors (PR: #56405) #56802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 10, 2024
| f"{test_input} has non list value {parsed_value} for path {test_path}. " | ||
| "Must be list or null." | ||
| f"Path must contain list or null, " | ||
| f"but got {type(test_input['info']).__name__} at {repr(test_path)}" |
There was a problem hiding this comment.
Could you fully evaluate {type(test_input['info']).__name__} and {repr(test_path)} here?
There was a problem hiding this comment.
Sure. BTW, I am not sure if the failed test is introduced by me or not. Should I fix it?
There was a problem hiding this comment.
I just changed {type(test_input['info']).__name__} to {type(parsed_value).__name__} since there are several tests based on different parameters and I can't fix the type name
mroeschke
added
Error Reporting
xiaohuanlin
force-pushed
the
change_prompt_on_pull_records
branch
from
304a0e3 to
bf65afc
Compare
mroeschke
approved these changes
Jan 10, 2024
|
Thanks @xiaohuanlin |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…#56405) (pandas-dev#56802) change the prompt on non list record path errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.